frontend/app/view/preview/directorypreview.tsx (3)

39-43: Consider extending or enumerating error handling states.
The new "FileCopyStatus" type is adequate but might benefit from distinguishing various error types or including error codes, allowing more robust handling of multiple failure scenarios.

---

912-931: Enhance error checking logic.
Relying on “.endsWith('overwrite not specified')” could be fragile if API error messages change. Consider a more structured approach (e.g., error codes) for robust retry checks.

---

963-964: Confirm complete dependency array.
If "handleDropCopy" is itself a dependency, consider adding it explicitly to align with React’s best practices, ensuring the drop callback always has the latest version of the function.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

frontend/app/view/preview/directorypreview.tsx (3)

39-43: Add JSDoc comments to document the type definition.

The FileCopyStatus type would benefit from documentation explaining the purpose of each field.

+/**
+ * Represents the status of a file copy operation.
+ */
 type FileCopyStatus = {
+    /** The data required for the copy operation */
     copyData: CommandFileCopyData;
+    /** Error message if the copy operation failed */
     copyError: string;
+    /** Whether the operation can be retried with overwrite flag */
     allowRetry: boolean;
 };

---

912-931: Improve error handling in the copy operation.

The error handling could be more robust:

1. Consider using a more specific error type instead of converting to string directly.
2. Add error classification to handle different types of errors differently.

 const handleDropCopy = useCallback(
     async (data: CommandFileCopyData) => {
         try {
             await RpcApi.FileCopyCommand(TabRpcClient, data, { timeout: data.opts.timeout });
             setCopyStatus(null);
         } catch (e) {
             console.log("copy failed:", e);
-            const copyError = `${e}`;
-            const allowRetry = copyError.endsWith("overwrite not specified");
+            // Classify error types
+            const copyError = e instanceof Error ? e.message : String(e);
+            const allowRetry = copyError.includes("overwrite not specified") || 
+                             copyError.includes("file exists");
             const copyStatus: FileCopyStatus = {
                 copyError,
                 copyData: data,
                 allowRetry,
             };
             setCopyStatus(copyStatus);
         }
         model.refreshCallback();
     },
     [setCopyStatus, model.refreshCallback]
 );

---

1135-1140: Improve error message presentation.

The error message handling could be more user-friendly and consistent.

-        let statusText = "Copy Error";
-        let errorMsg = `error: ${copyStatus?.copyError}`;
+        let statusText = copyStatus?.allowRetry ? "Confirm Overwrite" : "Copy Failed";
+        let errorMsg = copyStatus?.allowRetry
+            ? "One or more files already exist at the destination. Would you like to overwrite them?"
+            : `Failed to copy: ${copyStatus?.copyError}`;

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

frontend/app/view/preview/directorypreview.tsx (3)

912-931: Enhance error handling with specific error types and descriptive messages.

While the error handling is functional, it could be improved for better user experience and debugging.

Consider these improvements:

 async (data: CommandFileCopyData) => {
     try {
         await RpcApi.FileCopyCommand(TabRpcClient, data, { timeout: data.opts.timeout });
         setCopyStatus(null);
     } catch (e) {
-        console.log("copy failed:", e);
-        const copyError = `${e}`;
+        console.error("File copy operation failed:", e);
+        const errorMessage = e instanceof Error ? e.message : String(e);
+        const isOverwriteError = errorMessage.endsWith("overwrite not specified");
+        const copyError = isOverwriteError
+            ? "Cannot overwrite existing file without permission"
+            : `File copy failed: ${errorMessage}`;
         const allowRetry = copyError.endsWith("overwrite not specified");
         const copyStatus: FileCopyStatus = {
             copyError,
             copyData: data,
             allowRetry,
         };
         setCopyStatus(copyStatus);
     }
     model.refreshCallback();
 }

---

1124-1133: Optimize retry function memoization.

The retry function's dependency array could be optimized to prevent unnecessary re-renders.

 const handleRetryCopy = React.useCallback(async () => {
     if (!copyStatus) {
         return;
     }
     const updatedData = {
         ...copyStatus.copyData,
         opts: { ...copyStatus.copyData.opts, overwrite: true },
     };
     await handleDropCopy(updatedData);
-}, [copyStatus.copyData]);
+}, [copyStatus?.copyData, handleDropCopy]);

---

1153-1204: Enhance accessibility with ARIA labels and keyboard navigation.

The error overlay could be more accessible with proper ARIA attributes and keyboard support.

 <div
     ref={overlayRefCallback}
+    role="dialog"
+    aria-label={statusText}
+    aria-describedby="error-message"
     className="absolute top-[0] left-1.5 right-1.5 z-[var(--zindex-block-mask-inner)] overflow-hidden bg-[var(--conn-status-overlay-bg-color)] backdrop-blur-[50px] rounded-md shadow-lg"
 >
     {/* ... */}
-    <div>{errorMsg}</div>
+    <div id="error-message">{errorMsg}</div>
     {/* ... */}
     <Button
         className={buttonClassName}
+        onKeyDown={(e) => {
+            if (e.key === 'Escape') {
+                handleRemoveCopyError();
+            }
+        }}
         onClick={handleRemoveCopyError}
     >

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro